Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestLookupHostCancel failures with "lookup invalid.invalid: no such host" on Darwin #38767

Closed
bcmills opened this issue Apr 30, 2020 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-Darwin release-blocker
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 30, 2020

--- FAIL: TestLookupHostCancel (0.79s)
    lookup_test.go:947: LookupHost("invalid.invalid"): failed with unexpected error: lookup invalid.invalid: no such host
FAIL
FAIL	net	9.072s

2020-04-30T08:07:39-5c9a8c0/darwin-amd64-10_15
2020-04-30T00:33:38-df2862c/darwin-amd64-10_14
2020-04-21T14:57:43-af55060/darwin-amd64-10_15
2020-03-20T19:24:37-c505865/darwin-amd64-10_14
2019-10-28T18:06:12-91f3997/darwin-amd64-race

See previously #31950 (same failure mode on Windows), #25694 (same test but different failure mode on Darwin).

CC @mikioh @bradfitz @ianlancetaylor

@bcmills bcmills added OS-Darwin NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 30, 2020
@bcmills bcmills added this to the Backlog milestone Apr 30, 2020
@gopherbot
Copy link

Change https://golang.org/cl/369037 mentions this issue: net: don't check "invalid.invalid" lookup errors in TestLookupHostCancel

@bcmills bcmills self-assigned this Dec 3, 2021
@bcmills bcmills modified the milestones: Backlog, Go1.18 Dec 3, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Dec 8, 2021

This test has a fix CL out for review, and is a source of recurring failures on at least one builder. Marking as release-blocker via #11811.

@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Dec 8, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-Darwin release-blocker
Projects
None yet
Development

No branches or pull requests

2 participants