Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: high memory usage with VS Code remote dev in github.com/cockroachdb/cockroach #38752

Closed
stamblerre opened this issue Apr 29, 2020 · 2 comments
Closed

x/tools/gopls: high memory usage with VS Code remote dev in github.com/cockroachdb/cockroach #38752

stamblerre opened this issue Apr 29, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.2

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Apr 29, 2020 •
edited

Report on Slack:

huh, has anyone seen gopls taking 25+ 35 GiB of ram / getting OOMKilled?
strangely, it seems fine run locally on my laptop, where I only have 16gb total, but when I use VSCode’s remote dev feature, checking out the exact same codebase, but on a much bigger and beefier cloud VM, it gets OOMkilled a couple times a day with reported vm of 35GB. (edited)

Profiles:
gopls.30591-26GiB-goroutines.txt
gopls.30591-26GiB-heap.pb.gz

Local changes: https://github.com/cockroachdb/cockroach/compare/master...dt:gopls-oom?expand=1

/cc @heschik
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 29, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 29, 2020
@stamblerre stamblerre mentioned this issue May 8, 2020
Closed
@knz
Copy link

knz commented Jun 15, 2020

This issue has been addressed: #38080

which seems to reduce RAM usage considerably.

@heschi
Copy link
Contributor

heschi commented Jun 15, 2020

Great!

@heschi heschi closed this as completed Jun 15, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.2 Jun 18, 2020
@golang golang locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.2
Development

No branches or pull requests
4 participants
@knz @stamblerre @gopherbot @heschi