Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: tzdata not present on playground #38727

Closed
ecc1 opened this issue Apr 28, 2020 · 8 comments
Closed

x/playground: tzdata not present on playground #38727

ecc1 opened this issue Apr 28, 2020 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ecc1
Copy link

ecc1 commented Apr 28, 2020

The ParseInLocation example panics when run on the website:

2012-07-09 05:02:00 +0000 CEST
panic: time: missing Location in call to Date

goroutine 1 [running]:
time.Date(0x7dc, 0x7, 0x9, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/usr/local/go-faketime/src/time/time.go:1371 +0x630
time.parse(0x4d0251, 0xb, 0x4d025c, 0xb, 0x0, 0x0, 0x0, 0x0, 0xc000052180, 0x0, ...)
	/usr/local/go-faketime/src/time/format.go:1187 +0x2f0d
time.ParseInLocation(...)
	/usr/local/go-faketime/src/time/format.go:824
main.main()
	/tmp/sandbox338262955/prog.go:18 +0x1a7
@gopherbot gopherbot added this to the Unreleased milestone Apr 28, 2020
@andybons
Copy link
Member

time.LoadLocation is returning an error: unknown time zone Europe/Berlin

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 28, 2020
@andybons andybons changed the title x/website: https://golang.org/pkg/time/#example_ParseInLocation x/playground: tzdata not present on playground Apr 28, 2020
@andybons
Copy link
Member

Many of the time examples are not functioning: https://golang.org/pkg/time/#example_ParseInLocation

@toothrot

@andybons
Copy link
Member

@toothrot let me know if I can help with this at all.

@toothrot
Copy link
Contributor

Looks like we're missing zoneinfo:

UTC unknown time zone Europe/Berlin

@toothrot toothrot self-assigned this Apr 29, 2020
@gopherbot
Copy link

Change https://golang.org/cl/231057 mentions this issue: sandbox: fix missing timezone data

1 similar comment
@gopherbot

This comment has been minimized.

Sign in to view
@toothrot
Copy link
Contributor

Fixed, deployed sandbox, and cleared cache.

Thanks for reporting!

@ianlancetaylor
Copy link
Contributor

For what it's worth, once the playground uses 1.15 you could just compile the program with -tags timetzdata.

gopherbot pushed a commit to golang/playground that referenced this issue Apr 30, 2020
@toothrot
sandbox: fix missing timezone data
0298bc8 
The gvisor sandbox containers were missing tzinfo, as the busybox image
does not include it.

Updates golang/go#38727

Change-Id: Idc2c705e3ee31de1411507bb3abdf1afb28eeda9
Reviewed-on: https://go-review.googlesource.com/c/playground/+/231057
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@toothrot @andybons @ecc1 @ianlancetaylor @gopherbot