Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: fillreturns modifies existing returns #38707

Closed
stamblerre opened this issue Apr 27, 2020 · 2 comments
Closed

x/tools/gopls: fillreturns modifies existing returns #38707

stamblerre opened this issue Apr 27, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.2

Comments

@stamblerre
Copy link
Contributor

I added a return value to a function, and observed that hitting save overrode the existing values with nils. (Repro in the file golang.org/x/tools/internal/lsp/source/types_format.go`.)

Screen Shot 2020-04-27 at 3 44 54 PM
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 27, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 27, 2020
@gopherbot
Copy link

Change https://golang.org/cl/233527 mentions this issue: internal/lsp/source: don't mark fillreturns as high confidence

gopherbot pushed a commit to golang/tools that referenced this issue May 13, 2020
@stamblerre
internal/lsp/source: don't mark fillreturns as high confidence
78b527d 
It's not ready for the release yet (see golang/go#38707).

Change-Id: I04c1d8ec4ed815efb3e4c2d3c88cba3ec164755e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/233527
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@gopherbot
Copy link

Change https://golang.org/cl/236617 mentions this issue: internal/lsp/analysis/fillreturns: broaden type equality while filling incomplete return statements

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.2 Jun 18, 2020
@golang golang locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.2
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot