Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: TestTxCannotCommitAfterRollback flake #38701

Closed
mknyszek opened this issue Apr 27, 2020 · 2 comments
Closed

database/sql: TestTxCannotCommitAfterRollback flake #38701

mknyszek opened this issue Apr 27, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Apr 27, 2020

The test introduced by this change golang.org/cl/216240 has been flaking (albeit rarely) on both dashboard builders and trybots.

greplogs reveals:

2020-04-22T16:45:05-141b11d/windows-amd64-2008
2020-04-20T20:22:51-7004be9/windows-amd64-2008

and I have a trybot failure for an unrelated change: https://storage.googleapis.com/go-build-log/b4a5cdf0/linux-amd64-race_056b784c.log

The failure, to repeat it here, is:

--- FAIL: TestTxCannotCommitAfterRollback (0.00s)
    sql_test.go:2802: sql: no rows in result set
FAIL
FAIL	database/sql	0.724s

CC @kardianos @odeke-em

@mknyszek mknyszek added this to the Go1.15 milestone Apr 27, 2020
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 27, 2020
@kardianos
Copy link
Contributor

Those two failures were already noted and fixed with https://go-review.googlesource.com/c/go/+/229478 .

@mknyszek
Copy link
Contributor Author

Got it, my mistake was I only looked for open issues, and the base for my CL was a bit behind. Sorry for the noise.

@golang golang locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants