Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: inline comments not synchronized to GitHub #38689

Open
tklauser opened this issue Apr 27, 2020 · 0 comments
Open

x/build/cmd/gerritbot: inline comments not synchronized to GitHub #38689

tklauser opened this issue Apr 27, 2020 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@tklauser
Copy link
Member

What did you do?

  1. Opened tklauser: add my own main.go scratch#35 which got imported into Gerrit as https://go-review.googlesource.com/c/scratch/+/230213
  2. Replied with an inline code comment on the CL in Gerrit: https://go-review.googlesource.com/c/scratch/+/230213/1/tklauser/main.go#6

What did you expect to see?

Inline code comment synchronized to the GitHub PR by GerritBot.

What did you see instead?

GerritBot posted a comment to the PR, but the comment content was not added: golang/scratch#35 (comment)

Also, "global" reply comments on the CL get posted properly to the GitHub PR, see the "Testing with a CL comment" message https://go-review.googlesource.com/c/scratch/+/230213/2#message-7705eb20fe25b49c54c2c928532651e83a4e118f which got posted as golang/scratch#35 (comment)
@gopherbot gopherbot added this to the Unreleased milestone Apr 27, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 27, 2020
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 27, 2020
@dmitshur dmitshur mentioned this issue Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @tklauser @gopherbot