Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: pageAlloc.allocToCache updates pageAlloc.searchAddr in an invalid way [1.14 backport] #38606

Closed
gopherbot opened this issue Apr 22, 2020 · 3 comments
Closed

runtime: pageAlloc.allocToCache updates pageAlloc.searchAddr in an invalid way [1.14 backport] #38606

gopherbot opened this issue Apr 22, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.3

Comments

@gopherbot
Copy link

@mknyszek requested issue #38605 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open a backport issue for 1.14.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 22, 2020
@gopherbot gopherbot mentioned this issue Apr 22, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.3 milestone Apr 22, 2020
@mknyszek mknyszek self-assigned this Apr 22, 2020
@ianlancetaylor
Copy link
Contributor

Bug causes crashes with no workaround available. Cherry pick approved.

@ianlancetaylor ianlancetaylor added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 22, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/230377 mentions this issue: [release-branch.go1.14] runtime: ensure allocToCache updates searchAddr in a valid way

@gopherbot
Copy link
Author

Closed by merging 1b41fcb to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue May 1, 2020
@mknyszek @ianlancetaylor
[release-branch.go1.14] runtime: ensure allocToCache updates searchAd…
1b41fcb 
…dr in a valid way

Currently allocToCache assumes it can move the search address past the
block it allocated the cache from, which violates the property that
searchAddr should always point to mapped memory (i.e. memory represented
by pageAlloc.inUse).

This bug was already fixed once for pageAlloc.alloc in the Go 1.14
release via CL 216697, but that changed failed to take into account
allocToCache.

For #38605.
Fixes #38606.

Change-Id: Id08180aa10d19dc0f9f551a1d9e327a295560dff
Reviewed-on: https://go-review.googlesource.com/c/go/+/229577
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
(cherry picked from commit 287d1ec)
Reviewed-on: https://go-review.googlesource.com/c/go/+/230377
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
@golang golang locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.3
Development

No branches or pull requests
3 participants
@mknyszek @ianlancetaylor @gopherbot