Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestSegv consistently failing on NetBSD #38595

Closed
bcmills opened this issue Apr 22, 2020 · 5 comments
Closed

runtime: TestSegv consistently failing on NetBSD #38595

bcmills opened this issue Apr 22, 2020 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.15

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 22, 2020

The TestSegv function added in CL 228900 is failing consistently on the NetBSD 9.0 builders:

--- FAIL: TestSegv (0.00s)
    --- FAIL: TestSegv/Segv (0.01s)
        crash_cgo_test.go:569: 
        crash_cgo_test.go:571: expected crash from signal
    --- FAIL: TestSegv/SegvInCgo (0.01s)
        crash_cgo_test.go:569: 
        crash_cgo_test.go:571: expected crash from signal
…
FAIL
FAIL	runtime	41.529s

2020-04-22T00:01:14-e5bd6e1/netbsd-386-9_0
2020-04-22T00:01:14-e5bd6e1/netbsd-amd64-9_0

It's not clear to me whether the problem is in the test, the runtime, or the NetBSD kernel.

CC @ianlancetaylor @aclements
@bcmills bcmills added OS-NetBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Apr 22, 2020
@bcmills bcmills added this to the Go1.15 milestone Apr 22, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/229484 mentions this issue: runtime: sleep in TestSegv program to let signal be delivered

@josharian
Copy link
Contributor

Doesn't look like this is NetBSD-only. Looking at build.golang.org right now I see

darwin/amd64: https://build.golang.org/log/bf1f5e4990da13a459eec28e6eb3741ea253a084

linux/386: https://build.golang.org/log/bb4f8f764caf625ad4f339399c0fe0e65fdb6986

@ianlancetaylor
Copy link
Member

https://golang.org/cl/229484 should fix this, waiting for review by @bcmills .

@bcmills
Copy link
Contributor Author

bcmills commented Apr 24, 2020

Sorry, wasn't aware that it was ready for another pass. (There are unresolved comments on PS1.)

@ianlancetaylor
Copy link
Member

Sorry, I must have forgotten to hit send.

@josharian josharian mentioned this issue Apr 27, 2020
Closed
xujianhai666 pushed a commit to xujianhai666/go-1 that referenced this issue May 21, 2020
@ianlancetaylor @xujianhai666
runtime: sleep in TestSegv program to let signal be delivered
b049bce 
Since we're sleeping rather than waiting for the goroutines,
let the goroutines run forever.

Fixes golang#38595

Change-Id: I4cd611fd7565f6e8d91e50c9273d91c514825314
Reviewed-on: https://go-review.googlesource.com/c/go/+/229484
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
@golang golang locked and limited conversation to collaborators Apr 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
4 participants
@josharian @ianlancetaylor @bcmills @gopherbot