Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add configuration to disable links on hover #38573

Closed
shreyaskarnik opened this issue Apr 21, 2020 · 7 comments
Closed

x/tools/gopls: add configuration to disable links on hover #38573

shreyaskarnik opened this issue Apr 21, 2020 · 7 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
gopls/v0.4.4

Comments

@shreyaskarnik
Copy link

I am using gopls with VSCode and have the following setup in settings:

"go.languageServerExperimentalFeatures": {
    "documentLink": false,
  }

but still I see links to the documents
image

What version of Go are you using (go version)?

$ go version go1.14.2 darwin/amd64

gopls version information

golang.org/x/tools/gopls 0.4.0
    golang.org/x/tools/gopls@v0.4.0 h1:G4+YP9kaV4dJb79J5MobyApxX493Qa6VoiTceUmxqik=

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"

What did you do?

What did you expect to see?

I expected the links to be disabled
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Apr 21, 2020
@stamblerre
Copy link
Contributor

documentLink refers to the feature that makes links that appear in strings or comments clickable. There is no setting to control the links to the documentation that appear on hover (other than "gopls": { "hoverKind": "NoDocumentation" }, which would remove all documentation as well as the links).

@shreyaskarnik
Copy link
Author

@stamblerre thanks for the response! This release of gopls has been very stable and feature packed 🙌 ! Thanks again to everyone who made this possible!

@stamblerre
Copy link
Contributor

Glad to hear that it's working for you, @shreyu86! Thank you for the kind words!

I'll leave this issue open to see if we can add another configuration to remove the links on hover.

@stamblerre stamblerre changed the title tools/gopls: document link disable not working x/tools/gopls: add configuration to disable links on hover Jun 24, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 24, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 24, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Jun 24, 2020
@stamblerre
Copy link
Contributor

stamblerre commented Jul 14, 2020 •
edited

Sorry for the delay on this, @shreyaskarnik! I just realized we do have that configuration, actually.
Does adding the following to your settings.json resolve the issue?

"gopls": {
	"linkTarget": ""
}

@stamblerre stamblerre added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed Documentation help wanted labels Jul 14, 2020
@stamblerre
Copy link
Contributor

Looks like that worked. Closing this issue.

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.4 Jul 14, 2020
@shreyaskarnik
Copy link
Author

Thanks @stamblerre that worked!

@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
gopls/v0.4.4
Development

No branches or pull requests
3 participants
@shreyaskarnik @stamblerre @gopherbot