Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: stop caching Timeout errors #38546

Closed
toothrot opened this issue Apr 20, 2020 · 3 comments
Closed

x/playground: stop caching Timeout errors #38546

toothrot opened this issue Apr 20, 2020 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

The Playground mistakenly caches Timeout errors during builds or running of snippets. This is confusing to users if their build has timed out due to some instability. Some trivial play snippets that should have never timed out are now cached.

The (*server).commandHandler() function needs to be updated, as well as purging our existing cache.

/cc @bcmills @gus @dmitshur
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 20, 2020
@toothrot toothrot added this to the Unreleased milestone Apr 20, 2020
@toothrot toothrot self-assigned this Apr 20, 2020
@toothrot
Copy link
Contributor Author

Related to #38052

@toothrot toothrot mentioned this issue Apr 21, 2020
Open
@gopherbot
Copy link

Change https://golang.org/cl/229307 mentions this issue: playground: stop storing timeouts in cache

gopherbot pushed a commit to golang/playground that referenced this issue Apr 23, 2020
@toothrot
playground: stop storing timeouts in cache
11cd822 
This changes the Playground to stop storing build and run timeout
responses in the cache. These responses could get cached when the
Playground was unhealthy, leaving some trivial snippets to be cached
incorrectly, confusing users.

Adds testing for our caching logic.

Updates golang/go#38546
Updates golang/go#38576

Change-Id: Idd2106d673162d9eea8536fe2433f74c23ed6e8a
Reviewed-on: https://go-review.googlesource.com/c/playground/+/229307
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@randall77 randall77 mentioned this issue Apr 23, 2020
Closed
@toothrot
Copy link
Contributor Author

Fixed and flushed.

@golang golang locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@toothrot @gopherbot