Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/blog: https://blog.golang.org/10years missing images #38532

Closed
andrius4669 opened this issue Apr 20, 2020 · 9 comments
Closed

x/blog: https://blog.golang.org/10years missing images #38532

andrius4669 opened this issue Apr 20, 2020 · 9 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@andrius4669
Copy link
Contributor

I randomly noticed https://blog.golang.org/10years not having any images, even though there are links for them I see no img elements.
https://web.archive.org/web/20191109121218/https://blog.golang.org/10years properly have them.

What did you expect to see?

Screenshot from 2020-04-20 03-07-28

What did you see instead?

Screenshot from 2020-04-20 03-04-28
@andrius4669
Copy link
Contributor Author

(tested in both chromium and firefox but it's missing stuff in HTML so irrelevant)

@andrius4669
Copy link
Contributor Author

https://archive.vn/Tp0lc captured for the record

@mvdan
Copy link
Member

mvdan commented Apr 20, 2020

@dmitshur @andybons

@smasher164
Copy link
Member

smasher164 commented Apr 20, 2020 •
edited

Bisecting blog identifies golang/blog@d69e135 as the first commit, which pulls in golang/tools@e609210bcd3f from x/tools.
/cc @rsc

@smasher164 smasher164 added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 20, 2020
@egonelbre
Copy link
Contributor

egonelbre commented Apr 20, 2020 •
edited

It looks like tools/present parsing doesn't support .image nested inside an a tag anymore:

<a href="10years/gopher10th-large.jpg">
.image 10years/gopher10th-small.jpg _ 850
</a>

Based on a quick search, it seems 10 years of Go, is the only article using that syntax. Although there are others, such as experiment which is missing the images due to similar reasons.

<div style="margin-left: 2em;">
.image experiment/expsimp1.png _ 179
</div>

And https://blog.golang.org/gophergala seems to misformat the caption.

@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 20, 2020
@andybons andybons changed the title blog: https://blog.golang.org/10years missing images x/blog: https://blog.golang.org/10years missing images Apr 20, 2020
@andybons andybons added this to the Unreleased milestone Apr 20, 2020
@gopherbot
Copy link

Change https://golang.org/cl/251559 mentions this issue: x/blog: fix images so that they actually render

@seankhliao
Copy link
Member

Closing as this appears to be fixed

@egonelbre
Copy link
Contributor

@seankhliao there still seems to be a formatting issue here https://go.dev/blog/gophergala.

2021-09-14 14_24_31-Window

@gopherbot
Copy link

Change https://golang.org/cl/349849 mentions this issue: go.dev/_content/blog: fix caption formatting

gopherbot pushed a commit to golang/website that referenced this issue Mar 7, 2022
@seankhliao @dmitshur
blog: fix caption formatting
02f43ed 
Updates golang/go#38532

Change-Id: Iace87c755b7a7fbc64f0223e092f6e7f8eca06d4
Reviewed-on: https://go-review.googlesource.com/c/website/+/349849
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
7 participants
@egonelbre @andybons @mvdan @andrius4669 @gopherbot @seankhliao @smasher164