You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
go tool trace ./TestAnalyzeAnnotations.trace
2020/04/19 01:34:02 Parsing trace...
2020/04/19 01:34:02 Splitting trace...
2020/04/19 01:34:02 Opening browser. Trace viewer is listening on http://127.0.0.1:45911
visit trace ui and click on "User-defined regions"
click on any of the links under the "Counts" column
What did you expect to see?
A table of user regions.
What did you see instead?
The table of user regions is missing.
Analysis
The root cause turned out to be a simple encoding error when forming the link: the pc URL parameter is encoded in base 10 whereas the handler expects it be encoded in base 16.
In a local branch, I have the above fix plus some UX improvements that I found useful since I use runtime/trace User Annotation API frequently to debug issues in production.
Links to pprof style graphs and download links for region specific io, block, syscall and scheduler profiles. I was surprised that this functionality was implemented on the server, but not easily discoverable via the UI.
Table headers get a cursor: pointer CSS style on hover to signal to the user that they're in fact clickable (for sorting).
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
A table of user regions.
What did you see instead?
The table of user regions is missing.
Analysis
The root cause turned out to be a simple encoding error when forming the link: the
pc
URL parameter is encoded in base 10 whereas the handler expects it be encoded in base 16.In a local branch, I have the above fix plus some UX improvements that I found useful since I use
runtime/trace
User Annotation API frequently to debug issues in production.cursor: pointer
CSS style on hover to signal to the user that they're in fact clickable (for sorting).I'll go through the Contribution Guide and put up a review soon.
The text was updated successfully, but these errors were encountered: