Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: deleted files are being treated like orphaned files #38498

Closed
stamblerre opened this issue Apr 17, 2020 · 4 comments
Closed

x/tools/gopls: deleted files are being treated like orphaned files #38498

stamblerre opened this issue Apr 17, 2020 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.4

Comments

@stamblerre
Copy link
Contributor

Repro: Create and delete a package with one Go file in it. The logs will contain packages.Loads for this file that no longer exists, causing a huge slowdown. Somehow it never gets marked as "unloadable".
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 17, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 17, 2020
@heschi
Copy link
Contributor

heschi commented Jun 16, 2020

I can't reproduce this, at least not after https://golang.org/cl/238028.

@stamblerre
Copy link
Contributor Author

Neither can I. Closing.

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.4 Jul 9, 2020
@stamblerre
Copy link
Contributor Author

Reopening - I just had this happen to me. I deleted a file through the VS Code interface, and then immediately began experiencing a slowdown (laggy diagnostics). Looking at the logs, we were still constantly reloading the file and getting 0 packages for it.

@stamblerre stamblerre reopened this Jul 16, 2020
@gopherbot
Copy link

Change https://golang.org/cl/242924 mentions this issue: internal/lsp: don't keep track of closed overlays

@golang golang locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.4
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @heschi