Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: UI disappears with a small window #38482

Closed
egonelbre opened this issue Apr 16, 2020 · 6 comments
Closed

x/playground: UI disappears with a small window #38482

egonelbre opened this issue Apr 16, 2020 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@egonelbre
Copy link
Contributor

In https://play.golang.org/ when you click "Share" and the browser window area is less than 900px then the UI disappears.

2020-04-16 13_05_13-Window

@gopherbot gopherbot added this to the Unreleased milestone Apr 16, 2020
@smasher164 smasher164 assigned smasher164 and unassigned smasher164 Apr 16, 2020
@smasher164 smasher164 added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 16, 2020
@smasher164
Copy link
Member

Before the dropdown was added to the banner, that breakpoint was 775px.
Moving #shareURL, #embedLabel, and .js-playgroundToysEl from under #controls to under #banner fixes this issue, but extra styling must be applied to keep those elements inline with those inside #controls.

@egonelbre
Copy link
Contributor Author

Any reason not to switch to using flexbox which should behave better in presence of wrapping?

@smasher164
Copy link
Member

My solution above is more of a stop-gap measure. I believe the styling used in the updated golang.org design already has flexbox. There is a pending CL to update the playground with this design.

That being said, I agree with you that it's probably better to just switch to flexbox to address this issue, since future additions to the playground would only exacerbate this breakpoint.

/cc @andybons Thoughts?

@andybons
Copy link
Member

@egonelbre flexbox is fine with me. The playground UI was written far before that became a widely-supported feature.

@smasher164
Copy link
Member

I am working on a CL for this. Will send it shortly.

@gopherbot
Copy link

Change https://golang.org/cl/229419 mentions this issue: playground: use flexbox for navbar layout

@golang golang locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants