Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mod/zip: frequent TestVCS failures with 'exit status 128' #38466

Closed
bcmills opened this issue Apr 15, 2020 · 2 comments
Closed

x/mod/zip: frequent TestVCS failures with 'exit status 128' #38466

bcmills opened this issue Apr 15, 2020 · 2 comments
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 15, 2020 

--- FAIL: TestVCS (0.00s)
    --- FAIL: TestVCS/rsc.io_quote@v1.2.1 (31.77s)
        zip_test.go:944: fetch -f --depth=1 origin refs/tags/v1.2.1:refs/tags/v1.2.1: exit status 128
FAIL
FAIL	golang.org/x/mod/zip	37.493s

Some examples (a full list is hard to obtain due to #35515):

The specific repository that fails seems to vary from run to run. It's not clear to me whether this is a bug in x/mod/zip, a bug in git, a network issue on the linux-amd64-longtest builder, or unreliability in the upstream git servers.

CC @jayconrod @matloob @andybons
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. modules labels Apr 15, 2020
@gopherbot gopherbot added this to the Unreleased milestone Apr 15, 2020
@jayconrod jayconrod self-assigned this Apr 15, 2020
@jayconrod
Copy link
Contributor

I'm not too worried about git failures on this test. x/mod/zip doesn't directly interact with VCS tools; the test just does that to simulate how cmd/go drives it.

I would like to resolve the flakiness though. Perhaps a download error like this should cause the test to skip instead of fail.

@jayconrod jayconrod added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 15, 2020
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 15, 2020
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Apr 15, 2020
@gopherbot
Copy link

Change https://golang.org/cl/228397 mentions this issue: zip: in TestVCS, skip instead of failing after VCS error

@golang golang locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@jayconrod @bcmills @gopherbot