Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/imports: stdlib index is not updated for 1.14 #38464

Closed
smasher164 opened this issue Apr 15, 2020 · 2 comments
Closed

x/tools/internal/imports: stdlib index is not updated for 1.14 #38464

smasher164 opened this issue Apr 15, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@smasher164
Copy link
Member

This example (https://play.golang.org/p/oAVBRiJf04W) should import the log package when "Imports" is checked, and "Format" is clicked.
@smasher164 smasher164 added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 15, 2020
@gopherbot gopherbot added this to the Unreleased milestone Apr 15, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Apr 15, 2020
@gopherbot
Copy link

Change https://golang.org/cl/228884 mentions this issue: internal/imports: update stdlib index for 1.14

@gopherbot
Copy link

Change https://golang.org/cl/228889 mentions this issue: playground: update x/mod and x/tools

gopherbot pushed a commit to golang/playground that referenced this issue Apr 20, 2020
@smasher164 @toothrot
playground: update x/mod and x/tools
ede79dd 
This change pulls in the latest stdlib index indirectly by running

    $ go get golang.org/x/tools/imports
    $ go mod tidy

which depends on x/tools/internal/imports. As a consequence, using
symbols from 1.14, and formatting the source with "Imports" checked
should bring in that package. The following program should be
re-formatted to import hash/maphash:

    package main

    var _ = maphash.Seed

Updates golang/go#38464.

Change-Id: If5a1291b4a8c471b6a352032f8f9e4664de40106
Reviewed-on: https://go-review.googlesource.com/c/playground/+/228889
Run-TryBot: Akhil Indurti <aindurti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@smasher164 smasher164 mentioned this issue Apr 27, 2020
Closed
@golang golang locked and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @smasher164