Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/mail: mail.ParseAddress() does not handle comments correctly #38447

Open
robmccoll opened this issue Apr 14, 2020 · 3 comments
Open

net/mail: mail.ParseAddress() does not handle comments correctly #38447

robmccoll opened this issue Apr 14, 2020 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@robmccoll
Copy link

robmccoll commented Apr 14, 2020 •
edited

What version of Go are you using (go version)?

go version go1.14.2 linux/amd64
go go1.13.7 playground

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/rmccoll/.cache/go-build"
GOENV="/home/rmccoll/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/rmccoll/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build270827567=/tmp/go-build -gno-record-gcc-switches"

What did you do?

https://play.golang.org/p/SGqTDFa_wVA

package main

import (
	"fmt"
	"net/mail"
)

func main() {
	m, err := mail.ParseAddress(`Pete(A nice \) chap) <pete(his account)@silly.test(his host)>`)
	fmt.Println(m, err)
}

What did you expect to see?

As much as I would like it not to be, I believe this is a valid address perf RFC 5322. It is included as an example in Appendix A.5 White Space, Comments, and Other Oddities https://tools.ietf.org/html/rfc5322#appendix-A.5

"Pete" <pete@silly.test> <nil>

What did you see instead?

<nil> mail: missing @ in addr-spec
@andybons
Copy link
Member

@bradfitz

@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 14, 2020
@andybons andybons added this to the Unplanned milestone Apr 14, 2020
@robmccoll
Copy link
Author

robmccoll commented Apr 15, 2020 •
edited

In case it's useful or saves anyone time, I believe this is correct (but not exactly lovely). https://play.golang.org/p/3Qc9x6_d44t

@dustin-decker
Copy link

Here's another POC with [ ] in 41898282+github-actions[bot]@users.noreply.github.com

https://go.dev/play/p/KcZgHjHHVdD

@domodwyer domodwyer mentioned this issue Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@andybons @robmccoll @dustin-decker