Skip to content

cmd/compile: unexpected nil dereference on s390x [1.14 backport] #38443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 14, 2020 · 6 comments
Closed

cmd/compile: unexpected nil dereference on s390x [1.14 backport] #38443

gopherbot opened this issue Apr 14, 2020 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.3

Comments

@gopherbot
Copy link
Contributor

@mundaym requested issue #38195 to be considered for backport to the next 1.14 minor release.

@gopherbot please consider this for a backport

This is a bug in the register allocator that results in the compiled program behaving incorrectly. There is currently no workaround and it results in very hard to debug issues. It has only been seen to cause problems on s390x but theoretically it affects all platforms.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 14, 2020
@gopherbot gopherbot mentioned this issue Apr 14, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.3 milestone Apr 14, 2020
@andybons
Copy link
Member

@mundaym which CLs from the parent issue would you like to see backported?

@randall77 do you consider this a serious issue with no workaround as described above?

@randall77
Copy link
Contributor

I believe only CL 228061 is required. Michael, please confirm.

Yes, we should backport. This is a rare issue but is serious. It can lead to arbitrary bad execution.

@andybons
Copy link
Member

@randall77 thanks, Keith. Approved. Feel free to create the backport CLs for 1.14 and 1.13 per https://golang.org/wiki/MinorReleases.

@andybons andybons added the CherryPickApproved Used during the release process for point releases label Apr 27, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 27, 2020
@mundaym
Copy link
Member

mundaym commented Apr 27, 2020

I believe only CL 228061 is required. Michael, please confirm.

Yes, that is correct. The other CL is just an extra check to avoid a regression in future releases.

Feel free to create the backport CLs for 1.14 and 1.13 per https://golang.org/wiki/MinorReleases.

Thanks Andy and Keith. I'll do that now.

@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/230357 mentions this issue: [release-branch.go1.14] cmd/compile: fix deallocation of live value copies in regalloc

@gopherbot
Copy link
Contributor Author

Closed by merging c4b9269 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Apr 28, 2020
@mundaym @andybons
[release-branch.go1.14] cmd/compile: fix deallocation of live value c…
c4b9269 
…opies in regalloc

When deallocating the input register to a phi so that the phi
itself could be allocated to that register the code was also
deallocating all copies of that phi input value. Those copies
of the value could still be live and if they were the register
allocator could reuse them incorrectly to hold speculative
copies of other phi inputs. This causes strange bugs.

No test because this is a very obscure scenario that is hard
to replicate but CL 228060 adds an assertion to the compiler
that does trigger when running the std tests on linux/s390x
without this CL applied. Hopefully that assertion will prevent
future regressions.

Fixes #38443.

Change-Id: Id975dadedd731c7bb21933b9ea6b17daaa5c9e1d
Reviewed-on: https://go-review.googlesource.com/c/go/+/228061
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 382fe3e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/230357
@golang golang locked and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.3
Development

No branches or pull requests
4 participants
@andybons @randall77 @gopherbot @mundaym