Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: hyperlink does not inherit version #38429

Closed
tatsuhiro-t opened this issue Apr 14, 2020 · 1 comment
Closed

x/pkgsite: hyperlink does not inherit version #38429

tatsuhiro-t opened this issue Apr 14, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/dochtml Issues related to package documentation in pkgsite pkgsite

Comments

@tatsuhiro-t
Copy link

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

Browse versioned go.dev page:

https://pkg.go.dev/k8s.io/client-go@v0.18.1/kubernetes?tab=doc#Clientset.AdmissionregistrationV1

Check the hyperlink generated for admissionregistrationv1.AdmissionregistrationV1Interface

What did you expect to see?

The hyperlink should be https://pkg.go.dev/k8s.io/client-go@v0.18.1/kubernetes/typed/admissionregistration/v1?tab=doc#AdmissionregistrationV1Interface

What did you see instead?

The wrong hyperlink:

https://pkg.go.dev/k8s.io/client-go/kubernetes/typed/admissionregistration/v1?tab=doc#AdmissionregistrationV1Interface

@gopherbot gopherbot added this to the Unreleased milestone Apr 14, 2020
@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 20, 2020
@julieqiu julieqiu changed the title go.dev: Hyperlink does not inherit version x/pkgsite: Hyperlink does not inherit version Jun 15, 2020
@julieqiu julieqiu changed the title x/pkgsite: Hyperlink does not inherit version x/pkgsite: hyperlink does not inherit version Jun 15, 2020
@gopherbot
Copy link

Change https://golang.org/cl/241818 mentions this issue: internal/fetch: add versioning for import packages from same module

@shaqque shaqque self-assigned this Jul 9, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/dochtml Aug 19, 2020
@golang golang locked and limited conversation to collaborators Aug 19, 2021
@hyangah hyangah added the pkgsite/dochtml Issues related to package documentation in pkgsite label May 20, 2022
@rsc rsc unassigned shaqque Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/dochtml Issues related to package documentation in pkgsite pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants