Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: types regression for anonymous structs [1.14 backport] #38426

Closed
gopherbot opened this issue Apr 14, 2020 · 3 comments
Closed

cmd/cgo: types regression for anonymous structs [1.14 backport] #38426

gopherbot opened this issue Apr 14, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.3

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #38408 to be considered for backport to the next 1.14 minor release.

@gopherbot Please add issue for backport to Go 1.14.

This is an incompatible change to how cgo handles anonymous structs. There is no workaround for people using C headers that use the construct that changed incompatibly. We should fix this in the 1.14 branch.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 14, 2020
@gopherbot gopherbot mentioned this issue Apr 14, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.3 milestone Apr 14, 2020
@ianlancetaylor
Copy link
Member

Regression from 1.13. No workaround for people using existing C headers. Cherry pick approved.

@ianlancetaylor ianlancetaylor added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 14, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/228107 mentions this issue: [release-branch.go1.14] cmd/cgo: use consistent tag for a particular struct

@gopherbot
Copy link
Contributor Author

Closed by merging 768e5d1 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Apr 14, 2020
@ianlancetaylor
[release-branch.go1.14] cmd/cgo: use consistent tag for a particular …
768e5d1 
…struct

For #31891
For #38408
Fixes #38426

Change-Id: Ie7498c2cab728ae798e66e7168425e16b063520e
Reviewed-on: https://go-review.googlesource.com/c/go/+/228102
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
(cherry picked from commit 33ff63d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/228107
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.3
Development

No branches or pull requests
2 participants
@ianlancetaylor @gopherbot