Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: handle deletion of a directory on disk #38422

Closed
stamblerre opened this issue Apr 13, 2020 · 1 comment
Closed

x/tools/gopls: handle deletion of a directory on disk #38422

stamblerre opened this issue Apr 13, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
vscode-go: gopls by default
Milestone
gopls/v0.5.4

Comments

@stamblerre
Copy link
Contributor

This occurred after changing branches, causing a directory to be deleted on disk.
Diagnostics for all directories in the workspace were not propagated, leading to unreported errors.
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 13, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 13, 2020
@stamblerre stamblerre added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 13, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 13, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@stamblerre stamblerre changed the title x/tools/gopls: deleting a file on disk results in diagnostics for the nonexistent file x/tools/gopls: handle deletion of a directory on disk Oct 29, 2020
@gopherbot
Copy link

Change https://golang.org/cl/266138 mentions this issue: internal/lsp: handle deletion of a directory on disk

@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Critical to In progress in vscode-go: gopls by default Nov 11, 2020
@stamblerre stamblerre self-assigned this Nov 19, 2020
vscode-go: gopls by default automation moved this from In progress to Done Nov 19, 2020
@golang golang locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
vscode-go: gopls by default
  
Done
Milestone
gopls/v0.5.4
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot