Skip to content

x/tools/gopls: incorrect documentation for struct field #38417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stamblerre opened this issue Apr 13, 2020 · 1 comment
Closed

x/tools/gopls: incorrect documentation for struct field #38417

stamblerre opened this issue Apr 13, 2020 · 1 comment
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.1

Comments

@stamblerre
Copy link
Contributor

The image below shows a completion for a field of this struct: https://pkg.go.dev/golang.org/x/build/maintner?tab=doc#GitCommit. However, the documentation shows the docs for the struct, not for the field of the struct.

Screen Shot 2020-04-12 at 10 56 42 PM
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 13, 2020
@gopherbot gopherbot added Documentation Issues describing a change to documentation. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 13, 2020
@stamblerre stamblerre added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 14, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/228297 mentions this issue: internal/lsp: fix erroneous documentation for struct fields

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.1 May 13, 2020
@golang golang locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.1
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot