Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: undeclared types after adding new declarations in test file via git merge #38358

Closed
stamblerre opened this issue Apr 10, 2020 · 3 comments
Closed

x/tools/gopls: undeclared types after adding new declarations in test file via git merge #38358

stamblerre opened this issue Apr 10, 2020 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.1

Comments

@stamblerre
Copy link
Contributor

This needs a regression test and a fix. Reported as a result of a git merge that brought in new type declarations in a new test file. This is in an in-package test, in case that matters.
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 10, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 10, 2020
@stamblerre stamblerre mentioned this issue Apr 10, 2020
Closed
@stamblerre stamblerre mentioned this issue May 5, 2020
Closed
@pjweinb pjweinb added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 18, 2020
@pjweinb
Copy link

pjweinb commented May 18, 2020

Do we have a reproducible example of this?

@stamblerre
Copy link
Contributor Author

I do have a regression test in progress that we can probably build off of: https://go-review.googlesource.com/c/tools/+/233657.

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@gopherbot
Copy link

Change https://golang.org/cl/253797 mentions this issue: gopls/internal/regtest: add a test for new symbols in test variants

@stamblerre stamblerre self-assigned this Sep 9, 2020
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.1 Sep 16, 2020
@golang golang locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.1
Development

No branches or pull requests
3 participants
@pjweinb @stamblerre @gopherbot