Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: TestOpenat2 failing on ARM builders #38357

Closed
bcmills opened this issue Apr 10, 2020 · 5 comments
Closed

x/sys/unix: TestOpenat2 failing on ARM builders #38357

bcmills opened this issue Apr 10, 2020 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Linux Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 10, 2020

TestOpenat2, added in CL 227280, is failing with operation not permitted on multiple ARM builders:
https://build.golang.org/log/93bf4826da2c7a6f4ae3d423435e773d9a5783c4
https://build.golang.org/log/0e555617f2a3b124e7604af976cf4f56d182b74a

Either the test should be fixed ASAP or the CL should be reverted.

CC @kolyshkin @tklauser @ianlancetaylor for x/sys, @andybons for builder status
@bcmills bcmills added OS-Linux NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Apr 10, 2020
@gopherbot gopherbot added this to the Unreleased milestone Apr 10, 2020
@andybons
Copy link
Member

Let’s just revert.

@gopherbot
Copy link

Change https://golang.org/cl/227846 mentions this issue: Revert "unix: add openat2 for linux"

@kolyshkin
Copy link
Contributor

Can't we just revert a test case?

@gopherbot
Copy link

Change https://golang.org/cl/227865 mentions this issue: unix: fix TestOpenat2 failure on ARM

@bcmills
Copy link
Contributor Author

bcmills commented Apr 11, 2020

If the test is supposed to verify the functionality, then a falling test indicates that either the functionality is broken, or the test doesn't accurately describe the conditions under which it is supposed to work.

Either way, there's little harm in reverting the change: it can be re-submitted with a fix once someone figures out why the test is falling.

@golang golang locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Linux Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@andybons @kolyshkin @bcmills @gopherbot