-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/image/webp: "non-Alpha VP8X is not implemented" error while doing DecodeConfig #38341
Comments
oops, didn't notice already closed #25738 before posting this. |
quite simple tweak of source should sorta fix this at least for me (I only use DecodeConfig to detect file format and check image dimensions)
I'm not really sure how to contribute to x/image repo yet. |
Change https://golang.org/cl/230137 mentions this issue: |
https://play.golang.org/p/Yf77mdmNEZM small self-contained repro (not smallest possible though, just random small gif I found online and converted to webp) |
Change https://golang.org/cl/249445 mentions this issue: |
We already support VP8 + alpha, but reject e.g. VP8 + EXIF. After this commit, we still don't implement VP8 + EXIF (or ANIM, ICCP, etc.), but we now silently ignore the EXIF chunk instead of rejecting it. Fixes golang/go#25738, golang/go#38341 Change-Id: I4e9cdb718f0768f34336eab9528b82d2c40a3ee1 GitHub-Last-Rev: a0c2e53 GitHub-Pull-Request: #5 Reviewed-on: https://go-review.googlesource.com/c/image/+/249445 Trust: David Symonds <dsymonds@golang.org> Reviewed-by: Nigel Tao <nigeltao@golang.org>
Seems to be fixed by golang/image@3a743ba |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
yep.
What operating system and processor architecture are you using (
go env
)?(probably irrelevant so won't include yet)
What did you do?
Quick repro program:
ran it against https://0x0.st/iS94.webp
What did you expect to see?
No error. If it's able to recognize format and extract metadata, it should return them without raising error, even if it wouldn't be able to fully decode image.
What did you see instead?
tumblr_py63povN441yw147jo1_250.webp err: webp: non-Alpha VP8X is not implemented
The text was updated successfully, but these errors were encountered: