Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/loader: TestStdlib is failing on tip because TestTempFile was moved #38318

Closed
dmitshur opened this issue Apr 9, 2020 · 4 comments
Closed

x/tools/go/loader: TestStdlib is failing on tip because TestTempFile was moved #38318

dmitshur opened this issue Apr 9, 2020 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Apr 9, 2020

CL 226877 has moved the function TestTempFile from io/ioutil internal test to external test. TestStdlib is now failing:

$ gotip test
[...]
--- FAIL: TestStdlib (10.54s)
    stdlib_test.go:103: package "io/ioutil" has no func "TestTempFile"
    stdlib_test.go:117: GOMAXPROCS:            8
    stdlib_test.go:118: #Source lines:         1303424
    stdlib_test.go:119: Load/parse/typecheck:  10.070588601s
    stdlib_test.go:120: #MB:                   1068
FAIL
exit status 1
FAIL	golang.org/x/tools/go/loader	19.542s

Spotted on build.golang.org.

/cc @ianthehat @matloob per owners.
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository. labels Apr 9, 2020
@dmitshur dmitshur added this to the Unreleased milestone Apr 9, 2020
@dmitshur dmitshur mentioned this issue Apr 9, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/227772 mentions this issue: go/loader: delete stdlib_test.go

@stamblerre
Copy link
Contributor

Out of curiosity, why wasn't this issue caught in https://golang.org/cl/226877? I thought the tools TryBots had been configured to run on changes in the Go repo?

@dmitshur
Copy link
Contributor Author

@stamblerre It's because TestStdlib is skipped in -short mode. Only longtest post-submit builders run in non-short test mode.

@stamblerre
Copy link
Contributor

Ah, thanks for clarifying!

@golang golang locked and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @stamblerre @gopherbot