Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: upgrade runsc version #38317

Closed
prattmic opened this issue Apr 8, 2020 · 3 comments
Closed

x/playground: upgrade runsc version #38317

prattmic opened this issue Apr 8, 2020 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@prattmic
Copy link
Member

prattmic commented Apr 8, 2020

The root playground fs contains a __runsc_containers__ entry, which was removed from runsc in July 2019: https://play.golang.org/p/_bvQjtzhkuR, google/gvisor@04cbb13

Downloading the runsc binary from https://go.googlesource.com/playground/+/refs/heads/master/sandbox/cloud-init.yaml#15, runsc --version is not supported. This flag was added to runsc in April 2019: google/gvisor@7543e9e

Together, these make it seem like the runsc build is quite old? Once the new playground is stable, we'll want to be sure to update runsc regularly (official releases: https://github.com/google/gvisor/releases) to keep up with security fixes.
@gopherbot gopherbot added this to the Unreleased milestone Apr 8, 2020
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 8, 2020
@toothrot
Copy link
Contributor

toothrot commented Apr 8, 2020

Thanks, @prattmic!

Tagging #25224 for context.

@toothrot toothrot added this to In Progress in Go Release Team Feb 23, 2021
@gopherbot
Copy link

Change https://golang.org/cl/295650 mentions this issue: sandbox: always use latest runsc version

Go Release Team automation moved this from In Progress to Done Feb 24, 2021
@toothrot
Copy link
Contributor

Deployed. We'll now stay up to date when we restart our sandbox instances.

@golang golang locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @prattmic @gopherbot