Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: over quota for compute.googleapis.com ListInstances #38315

Closed
toothrot opened this issue Apr 8, 2020 · 2 comments
Closed

x/playground: over quota for compute.googleapis.com ListInstances #38315

toothrot opened this issue Apr 8, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

toothrot commented Apr 8, 2020 •
edited

The playground project is going over quota for ListInstances, likely from the poller in gcpdial: https://github.com/golang/playground/blob/15e968511d3060ae3d38f53ab43cc48529d26825/internal/gcpdial/gcpdial.go#L190

We should introduce a ticker here to not hit our quota of 10000 requests per 100 seconds.
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 8, 2020
@toothrot toothrot added this to the Unreleased milestone Apr 8, 2020
@toothrot toothrot self-assigned this Apr 8, 2020
@gopherbot
Copy link

Change https://golang.org/cl/227648 mentions this issue: playground/internal/gcpdial: throttle polling for instances

gopherbot pushed a commit to golang/playground that referenced this issue Apr 15, 2020
@toothrot
internal/gcpdial: throttle polling for instances
0a10c62 
gcpdial polls for instances in case instances from the sandbox instance
group change. Unfortunately, it is causing us to go over quota in our
production project, which breaks other services (mainly deploying from
Cloud Build).

This change introduces a 10s ticker. Verified locally using
internal/gcpdial/gcpdialtool.

Updates golang/go#38315

Change-Id: I36009397233c6fc1663a7f2cee4f47caea1ca161
Reviewed-on: https://go-review.googlesource.com/c/playground/+/227648
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@toothrot
Copy link
Contributor Author

This has been resolved. Down from 80QPS to ~40.

@golang golang locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@toothrot @gopherbot