Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: newTrySet provides invalid goBranch value to dashboard.TryBuildersForProject when testing custom branches of golang.org/x repos #38303

Closed
dmitshur opened this issue Apr 8, 2020 · 1 comment
Closed

x/build/cmd/coordinator: newTrySet provides invalid goBranch value to dashboard.TryBuildersForProject when testing custom branches of golang.org/x repos #38303

dmitshur opened this issue Apr 8, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Apr 8, 2020

cmd/coordinator makes an assumption that is not safe to make here:

https://github.com/golang/build/blob/39561bf34556f888d43bce0ed218426494ecd88c/cmd/coordinator/coordinator.go#L1167-L1169

This is because dashboard.TryBuildersForProject may not return any builders when given a non-existing goBranch value, or it may return the wrong ones.

Spotted while reviewing CL 227397, but it's not critical to fix for #37512 because dashboard.TryBuildersForProject doesn't filter out by goBranch too aggressively at this time. Filing an issue so we don't forget.

/cc @cagedmantis @toothrot
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Apr 8, 2020
@dmitshur dmitshur added this to the Unreleased milestone Apr 8, 2020
@dmitshur dmitshur mentioned this issue Oct 21, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/319791 mentions this issue: cmd/coordinator: use better value for GoBranch

@golang golang locked and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot