Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/rpc: client's DialHTTPPath() treats http CONNECT response incorrectly #38297

Open
AnimusPEXUS opened this issue Apr 7, 2020 · 1 comment
Open

net/rpc: client's DialHTTPPath() treats http CONNECT response incorrectly #38297

AnimusPEXUS opened this issue Apr 7, 2020 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@AnimusPEXUS
Copy link

AnimusPEXUS commented Apr 7, 2020 •
edited

https://tools.ietf.org/html/rfc7231#section-4.3.6 - says: 'Any 2xx (Successful) response indicates that the sender (and all inbound proxies) will switch to tunnel mode immediately after the
blank line that concludes the successful response's header section;'

but DialHTTPPath() requires exactly resp.Status == "200 Connected to Go RPC"

https://github.com/golang/go/blob/master/src/net/rpc/client.go#L258
if err == nil && resp.Status == connected {
https://github.com/golang/go/blob/master/src/net/rpc/server.go#L688
var connected = "200 Connected to Go RPC"
@andybons andybons changed the title net/rpc client's DialHTTPPath() treats http CONNECT response incorrectly net/rpc: client's DialHTTPPath() treats http CONNECT response incorrectly Apr 8, 2020
@andybons
Copy link
Member

andybons commented Apr 8, 2020

@robpike

@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 8, 2020
@andybons andybons added this to the Unplanned milestone Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
2 participants
@andybons @AnimusPEXUS