Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/internal/dl: linux/arm64 port is misreported by File.PrimaryPort as not first class #38258

Closed
ALTree opened this issue Apr 5, 2020 · 3 comments
Closed

x/website/internal/dl: linux/arm64 port is misreported by File.PrimaryPort as not first class #38258

ALTree opened this issue Apr 5, 2020 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ALTree
Copy link
Member

ALTree commented Apr 5, 2020

Background: #35593 (all: make linux/arm64 a first-class port). It was accepted, so the linux/arm64 port is a First Class Port.

According to PortingPolicy § First Class Ports, for a first class port:

Official binaries are provided

also it is noted that

We distribute binaries for other GOOS/GOARCH pairs (other "ports"), but they are not "first class" by this definition

But in the download page I see that for go 1.13.9 and go 1.14.1 linux-arm64.tar.gz | ARMv8 is listed under "Other Ports", which I believe is where we put ports we provide binaries for even if they're not First Class. Since arm64 is first class, it should be in the section above, with the other First Class Ports.

cc @dmitshur
@gopherbot gopherbot added this to the Unreleased milestone Apr 5, 2020
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 5, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Apr 7, 2020

Thanks for reporting and providing relevant background.

This looks like a bug in the golang.org/x/website/internal/dl package. It maintains a map of primary ports, and I suspect we need to update that to match #35593.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. help wanted and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 7, 2020
@dmitshur dmitshur changed the title x/website: arm64 listed under "Other Ports" in dl page, even if it's first class x/website/internal/dl: linux/arm64 port is misreported by File.PrimaryPort as not first class Apr 7, 2020
@gopherbot
Copy link

Change https://golang.org/cl/227597 mentions this issue: internal/dl: add linux/arm64 to the list of First Class ports

@dmitshur
Copy link
Contributor

dmitshur commented Apr 15, 2020 •
edited

The fix is deployed and visible at https://golang.org/dl/ now.

Thank you for sending a CL and fixing this issue, @ALTree.

@golang golang locked and limited conversation to collaborators Apr 15, 2021
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
internal/dl: add linux/arm64 to the list of First Class ports
325a6f4 
The PrimaryPort function is used in the dl page to split downloads
between first class and "Others". Since linux/arm64 is now a first
class port, it needs to be listed in the primary section.

Updates golang/go#35593
Fixes golang/go#38258

Change-Id: Ib3044b2feaad4b7b415d273fab014d83082c806f
Reviewed-on: https://go-review.googlesource.com/c/website/+/227597
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @ALTree @gopherbot