Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/cmd/gorelease: module go directive compatibility #38240

Closed
carnott-snap opened this issue Apr 3, 2020 · 2 comments
Closed

x/exp/cmd/gorelease: module go directive compatibility #38240

carnott-snap opened this issue Apr 3, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@carnott-snap
Copy link

I recall the impact of updating the go directive, e.g. go 1.11 -> go 1.14, on compatibility being discussed in CL 197299 but do not see a resolution. Does gorelease currently ignore this, and what should it do?
@gopherbot gopherbot added this to the Unreleased milestone Apr 3, 2020
@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 6, 2020
@andybons
Copy link
Member

andybons commented Apr 6, 2020

@jayconrod

@jayconrod
Copy link
Contributor

Thanks for the reminder. gorelease currently ignores this, but I think the resolution was that we should increment the minor version when the go version changes.

Let's track this in #37564. I've added a comment there.

@golang golang locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@jayconrod @andybons @gopherbot @carnott-snap