Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: NewTicker will not emit ticks at a frequency greater than 1/sec on qemu user mode ppc64le [1.13 backport] #38236

Closed
gopherbot opened this issue Apr 3, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@tklauser requested issue #36592 to be considered for backport to the next 1.13 minor release.

@gopherbot please consider this for backport to 1.13, it's a regression.

/cc @ianlancetaylor

@ianlancetaylor
Copy link
Contributor

Fixes a regression running on ppc64le QEMU, with no work around.

@ianlancetaylor ianlancetaylor added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 3, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/227179 mentions this issue: [release-branch.go1.13] runtime: fix wrong offset when calling ppc64x nanotime syscall

@gopherbot
Copy link
Author

Closed by merging b79c36d to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Apr 3, 2020
… nanotime syscall

There is a wrong offset when getting the results of a clock_gettime
syscall. Although the syscall will never be called in native ppc64x,
QEMU doesn't implement VDSO, so it will return wrong values.

For #36592
Fixes #38236

Change-Id: Icf838075228dcdd62cf2c1279aa983e5993d66ee
Reviewed-on: https://go-review.googlesource.com/c/go/+/215397
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
(cherry picked from commit 71239b4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/227179
Reviewed-by: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

2 participants