Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: no "Trybots beginning" message when running multiple times on the same patchset #38235

Closed
stamblerre opened this issue Apr 3, 2020 · 3 comments
Closed

x/build/cmd/coordinator: no "Trybots beginning" message when running multiple times on the same patchset #38235

stamblerre opened this issue Apr 3, 2020 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Apr 3, 2020 •
edited

I occasionally want to run TryBots multiple times on the same patchset. Based on the behavior on https://golang.org/cl/227117, it seems like this works, but it doesn't send out the "TryBots beginning" message with a link to their progress. This makes me think that the TryBots aren't running.

/cc @dmitshur @cagedmantis @toothrot
@gopherbot gopherbot added this to the Unreleased milestone Apr 3, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 3, 2020
@stamblerre stamblerre added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Builders x/build issues (builders, bots, dashboards) labels Apr 3, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 3, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Apr 3, 2020 •
edited

Thanks for reporting. This is indeed a problem for usability. (CC @prattmic who's run into this too.)

The reason it happens is because the message that coordinator constructs when trybots are restarted on the same commit ends up being identical to a previously posted one (because the commit hash is unchanged), and there is code to prevent duplicate messages from being posted:

https://github.com/golang/build/blob/61705b562fc995a53af15476c91f6ad3dcf1aae8/cmd/coordinator/coordinator.go#L1363

When that spam filter was created, we probably didn't anticipate this situation where duplicate messages are expected.

We should fix this either by adjusting the spam filter to permit duplicate "TryBots beginning" messages, or perhaps better, make it so that the message it posts isn't duplicate by adding " (attempt 2)", " (attempt 3)", etc., suffixes (if it's not too hard to compute what attempt it is).

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 3, 2020
@dmitshur dmitshur changed the title x/build: no "Trybots beginning" message when running multiple times on the same patchset x/build/cmd/coordinator: no "Trybots beginning" message when running multiple times on the same patchset Apr 3, 2020
@darkLord19 darkLord19 mentioned this issue Apr 6, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/227319 mentions this issue: cmd/coordinator: add attempt prefix to TryBot runs

@dmitshur dmitshur mentioned this issue Apr 23, 2020
Open
@dmitshur dmitshur mentioned this issue Oct 29, 2020
Open
@dmitshur
Copy link
Contributor

Based on commit message and discussion in CL 310186,
I understand this is fixed in golang/build@c328b27 (CL 310015).
(CC @FiloSottile, @ianlancetaylor.)

@golang golang locked and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

cmd/coordinator: add attempt prefix to TryBot runs
3 participants
@dmitshur @stamblerre @gopherbot