Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: show progress report when gopls is downloading a module #38233

Open
stamblerre opened this issue Apr 3, 2020 · 1 comment
Open

x/tools/gopls: show progress report when gopls is downloading a module #38233

stamblerre opened this issue Apr 3, 2020 · 1 comment
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@stamblerre
Copy link
Contributor

@ardan-bkennedy suggested that we should try to use the progress reporting functionality of LSP to indicate when a module is being downloaded by go/packages. Otherwise, we just have a slow save that don't give the user any indication that gopls is communicating with the network.

This will be tricky because only go/packages knows that it's downloading a module. My current best guess at how to do this is to put something in the config's Logf function...or maybe use a trick like packagesinternal?
@stamblerre stamblerre added this to the gopls/v0.4.0 milestone Apr 3, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 3, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.4.0, gopls/v0.5.0 Apr 3, 2020
@ianthehat
Copy link

If the internal/telemetry experiment is a success we could instrument the go/packages library using it and then gopls could register an exporter that tracks progress and reports it easily (the same way it already intercepts log messages and sends them as "window/logMessage")
It would also replace the existing Logf hooks in a much cleaner way.

@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jun 24, 2020
@stamblerre stamblerre changed the title x/tools/gopls: show when gopls is downloading a module x/tools/gopls: show progress report when gopls is downloading a module Jul 23, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
3 participants
@ianthehat @stamblerre @gopherbot