Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp/regtest: "context deadline exceeded" in TestDiagnosticErrorInNewFile/forwarded #38217

Closed
bcmills opened this issue Apr 2, 2020 · 2 comments
Closed

x/tools/internal/lsp/regtest: "context deadline exceeded" in TestDiagnosticErrorInNewFile/forwarded #38217

bcmills opened this issue Apr 2, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.2

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 2, 2020

https://build.golang.org/log/5e788def16a08add4c80a64d8f88db4c604a655e

--- FAIL: TestDiagnosticErrorInNewFile (64.09s)
    --- FAIL: TestDiagnosticErrorInNewFile/forwarded (60.01s)
        diagnostics_test.go:64: waiting on [diagnostic in "broken.go" at {line:2, column:12} (location of "\"abc")]:
            err:context deadline exceeded
            diagnostics:
panic: Shutdown: context deadline exceeded [recovered]
	panic: Shutdown: context deadline exceeded

goroutine 9423 [running]:
testing.tRunner.func1.1(0xe748e0, 0xc00225b3c0)
	/tmp/workdir/go/src/testing/testing.go:941 +0x421
testing.tRunner.func1(0xc000fa66c0)
	/tmp/workdir/go/src/testing/testing.go:944 +0x600
panic(0xe748e0, 0xc00225b3c0)
	/tmp/workdir/go/src/runtime/panic.go:975 +0x3c2
golang.org/x/tools/internal/lsp/regtest.(*Runner).RunInMode.func1.1(0xc000fca7e0, 0x10e3100, 0xc000fca300)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/env.go:182 +0xc1
runtime.Goexit()
	/tmp/workdir/go/src/runtime/panic.go:636 +0x104
testing.(*common).FailNow(0xc000fa66c0)
	/tmp/workdir/go/src/testing/testing.go:658 +0x5b
testing.(*common).Fatalf(0xc000fa66c0, 0xf929c2, 0x27, 0xc0038e5ba0, 0x3, 0x3)
	/tmp/workdir/go/src/testing/testing.go:725 +0x9e
golang.org/x/tools/internal/lsp/regtest.(*Env).Await(0xc000fca7e0, 0xc001ad70c0, 0x1, 0x1)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/env.go:392 +0x6f2
golang.org/x/tools/internal/lsp/regtest.TestDiagnosticErrorInNewFile.func1(0xc000fca7e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/diagnostics_test.go:64 +0x136
golang.org/x/tools/internal/lsp/regtest.(*Runner).RunInMode.func1(0xc000fa66c0)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/env.go:185 +0x398
testing.tRunner(0xc000fa66c0, 0xc002679950)
	/tmp/workdir/go/src/testing/testing.go:992 +0x1ec
created by testing.(*T).Run
	/tmp/workdir/go/src/testing/testing.go:1043 +0x661
FAIL	golang.org/x/tools/internal/lsp/regtest	118.918s

The failure mode looks similar to #37318 (CC @stamblerre @findleyr).
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. labels Apr 2, 2020
@gopherbot gopherbot added this to the Unreleased milestone Apr 2, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Apr 2, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Apr 2, 2020
@findleyr
Copy link
Contributor

This might not be the same as #37318, so I'm leaving it open until I can confirm.

As with that bug, fixing this may be a slow process of elimination and adding additional instrumentation, until we find the root cause(s). This process is currently ongoing.

The frequency of flakes is, in my opinion, not high enough yet to warrant disabling tests, given that these tests guard against specific regressions we'd like to avoid in the future.

@findleyr findleyr self-assigned this Apr 16, 2020
@findleyr
Copy link
Contributor

I think I've categorized known flakes in #37318. Closing this to consolidate effort there.

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.2 Jun 19, 2020
@golang golang locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.2
Development

No branches or pull requests
4 participants
@bcmills @stamblerre @gopherbot @findleyr