Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: enable type error analyses #38212

Closed
stamblerre opened this issue Apr 2, 2020 · 1 comment
Closed

x/tools/gopls: enable type error analyses #38212

stamblerre opened this issue Apr 2, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.1

Comments

@stamblerre
Copy link
Contributor

Since these are fairly new analyzers, they will be disabled by default in gopls/v0.4.0 release. They should be enabled by gopls/v0.5.0.

/cc @ridersofrohan
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 2, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 2, 2020
@gopherbot
Copy link

Change https://golang.org/cl/226962 mentions this issue: internal/lsp: temporarily disable type error analyzers by default

gopherbot pushed a commit to golang/tools that referenced this issue Apr 2, 2020
@stamblerre
internal/lsp: temporarily disable type error analyzers by default
3304cfb 
If we release gopls/v0.4.0 soon, we should keep these new analyzers off
by default. They were just merged, so they haven't been used enough to
be enabled, I think. We'll turn them on by default for gopls/v0.5.0.

Also, ended up creating a helper function to check if analysis has been
abled (which fixed a small bug in FindAnalysisError), and another helper
function to enable all analyses for testing purposes.

Updates golang/go#38212

Change-Id: I5ee94b3582dfc0863978650fc6ce51bfa0606c13
Reviewed-on: https://go-review.googlesource.com/c/tools/+/226962
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rohan Challa <rohan@golang.org>
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.1 May 13, 2020
@golang golang locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.1
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot