You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're using modules in a project that already broke the v2+ rules regarding package structure before modules were a thing, we would still like to be able to use modules and so far have been able to by adding +incompatible to the module require statement when importing the project in question.
While this allows go test and go build to work is causes go mod download to fail.
I understand the point of having best practices and forcing +incompatible on packages that break these practices but there should not be anything that stops us from doing this if we explicitly set it as such.
My concern is if download is broken today and not test and build, is it likely that test and build will eventually follow this behavior? If that's the case it will break a number of things in our stack; I don't think it makes sense to break users, whether for the "greater good" or not.
It's worth noting that go mod vendor also works currently, if there are no plans to change this behavior with relation to test, build and vendor then this is not an issue but I would rather find out ahead of time if this behavior is likely to change for the reason listed above.
What did you expect to see?
all packages downloaded successfully
What did you see instead?
bitbucket.org/redeam/core@v3.5.7+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required
The text was updated successfully, but these errors were encountered:
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
We're using modules in a project that already broke the v2+ rules regarding package structure before modules were a thing, we would still like to be able to use modules and so far have been able to by adding
+incompatible
to the module require statement when importing the project in question.While this allows
go test
andgo build
to work is causesgo mod download
to fail.I understand the point of having best practices and forcing
+incompatible
on packages that break these practices but there should not be anything that stops us from doing this if we explicitly set it as such.My concern is if
download
is broken today and nottest
andbuild
, is it likely thattest
andbuild
will eventually follow this behavior? If that's the case it will break a number of things in our stack; I don't think it makes sense to break users, whether for the "greater good" or not.It's worth noting that
go mod vendor
also works currently, if there are no plans to change this behavior with relation totest
,build
andvendor
then this is not an issue but I would rather find out ahead of time if this behavior is likely to change for the reason listed above.What did you expect to see?
all packages downloaded successfully
What did you see instead?
bitbucket.org/redeam/core@v3.5.7+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required
The text was updated successfully, but these errors were encountered: