Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/blog: build broken on js-wasm builder #38183

Closed
bcmills opened this issue Mar 31, 2020 · 2 comments
Closed

x/blog: build broken on js-wasm builder #38183

bcmills opened this issue Mar 31, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 31, 2020

The x/blog build is broken on the js-wasm builder as of CL 223477.

It appears that github.com/yuin/goldmark/util, a dependency newly added in that CL, lacks an implementation of two functions when the js build tag is present.

CC @rsc @ianlancetaylor @yuin
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Mar 31, 2020
@gopherbot gopherbot added this to the Unreleased milestone Mar 31, 2020
@bcmills bcmills mentioned this issue Mar 31, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/226560 mentions this issue: go.mod: upgrade goldmark dependency to fix js/wasm build

gopherbot pushed a commit to golang/tools that referenced this issue Mar 31, 2020
go.mod: upgrade goldmark dependency to fix js/wasm build
ac2e956 
For golang/go#38183
Updates yuin/goldmark#120

Change-Id: I913c3409fe0c774209ce046a85699ef845e7c7b3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/226560
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/226638 mentions this issue: go.mod: upgrade x/tools to pull in goldmark fix for js/wasm

@bcmills bcmills self-assigned this Mar 31, 2020
@golang golang locked and limited conversation to collaborators Mar 31, 2021
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
[x/blog] go.mod: upgrade x/tools to pull in goldmark fix for js/wasm
37c7105 
Fixes golang/go#38183

Change-Id: I418fd8c16bd5800d7b4884e764b2b3b17319ea1e
Reviewed-on: https://go-review.googlesource.com/c/blog/+/226638
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
X-Blog-Commit: 45267ae64cfc3e9f6c3d21d2a0e65851ad1413f0
@rsc rsc unassigned bcmills Jun 23, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
[x/blog] go.mod: upgrade x/tools to pull in goldmark fix for js/wasm
01ab101 
Fixes golang/go#38183

Change-Id: I418fd8c16bd5800d7b4884e764b2b3b17319ea1e
Reviewed-on: https://go-review.googlesource.com/c/blog/+/226638
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
X-Blog-Commit: 45267ae64cfc3e9f6c3d21d2a0e65851ad1413f0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot