Skip to content

x/exp/ebnflint: TestSpec persistently failing on Android builders #38182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Mar 31, 2020 · 1 comment
Closed

x/exp/ebnflint: TestSpec persistently failing on Android builders #38182

bcmills opened this issue Mar 31, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 31, 2020

CL 220017 re-enabled x/exp/ebnflint.TestSpec on all builders for #37290.

Unfortunately, that test does not pass on the Android builders: it examines GOROOT/doc/go_spec.html, but the Android builders do not copy the full GOROOT over to the builder for every test.

The test should probably be updated to skip if the file does not exist.

CC @griesemer @ianlancetaylor @fzipp
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Mar 31, 2020
@gopherbot gopherbot added this to the Unreleased milestone Mar 31, 2020
@griesemer griesemer self-assigned this Mar 31, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/226677 mentions this issue: exp/ebnflint: skip test if spec is not found

@golang golang locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @griesemer @gopherbot