Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/publicsuffix: Release as a separate module #38169

Closed
tamalsaha opened this issue Mar 30, 2020 · 4 comments
Closed

x/net/publicsuffix: Release as a separate module #38169

tamalsaha opened this issue Mar 30, 2020 · 4 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@tamalsaha
Copy link

What did you expect to see?

Since https://github.com/golang/net/tree/master/publicsuffix includes a generated
table.go file, it will be really helpful if the publicsuffix can be made its own module. This will allow us to use the latest publicsuffix module with an old version of x/net module.

What did you see instead?
@gopherbot gopherbot added this to the Unreleased milestone Mar 30, 2020
@ALTree ALTree added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 31, 2020
@bcmills
Copy link
Contributor

bcmills commented Apr 1, 2020

Why do you want to use an old version of x/net?

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Apr 1, 2020
@tamalsaha
Copy link
Author

We have a dependency on Kubernetes. We just use whatever go.mod automatically picks based on that dependency.

@bcmills
Copy link
Contributor

bcmills commented Apr 3, 2020

Sure, but why is that preferable to using an upgraded x/net? (What, if any, harm does a newer x/net cause?)

@ALTree
Copy link
Member

ALTree commented Jun 18, 2021

This has been in waiting for info for more than a year, usecase still unclear, seems like there's not a lot of interest in making pubblicsuffix its own module, I think we can close.

@ALTree ALTree closed this as completed Jun 18, 2021
@golang golang locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@tamalsaha @ALTree @bcmills @gopherbot