Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: change rpc debug handling to not use the metrics package #38168

Closed
ianthehat opened this issue Mar 30, 2020 · 1 comment
Closed

x/tools/internal/lsp: change rpc debug handling to not use the metrics package #38168

ianthehat opened this issue Mar 30, 2020 · 1 comment
Labels
FeatureRequest FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.2

Comments

@ianthehat
Copy link

The rpc debugging system for legacy reasons is using the metrics package when it would be easier to just monitor the events itself.
@ianthehat ianthehat added FeatureRequest gopls Issues related to the Go language server, gopls. labels Mar 30, 2020
@ianthehat ianthehat self-assigned this Mar 30, 2020
@gopherbot gopherbot added this to the Unreleased milestone Mar 30, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Mar 30, 2020
@gopherbot
Copy link

Change https://golang.org/cl/227139 mentions this issue: internal/lsp: rewritre the rpc debug page

@stamblerre stamblerre modified the milestones: gopls/v0.6.0, gopls/v0.4.2 Jun 24, 2020
@golang golang locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.2
Development

No branches or pull requests
3 participants
@ianthehat @stamblerre @gopherbot