Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/signal: TestStop/user_defined_signal_1 failing on android-arm{,64}-corellium builders #38165

Closed
bcmills opened this issue Mar 30, 2020 · 3 comments
Closed

os/signal: TestStop/user_defined_signal_1 failing on android-arm{,64}-corellium builders #38165

bcmills opened this issue Mar 30, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Milestone
Go1.15

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 30, 2020

I appear to have broken TestStop for SIGUSR1 in CL 226138.

I'm not sure why it's broken. I'll add a Skip for now.

2020-03-30T17:35:19-3ee782b/android-arm-corellium
2020-03-30T17:35:19-3ee782b/android-arm64-corellium

CC @ianlancetaylor
@bcmills bcmills added OS-Android NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. CherryPickCandidate Used during the release process for point releases labels Mar 30, 2020
@gopherbot
Copy link

Change https://golang.org/cl/226458 mentions this issue: os/signal: in TestStop, skip the final "unexpected signal" check for SIGUSR1 on Android

@bcmills
Copy link
Contributor Author

bcmills commented Mar 30, 2020 •
edited

CL 203957 seems closely related (CC @aclements, @cherrymui, @mknyszek)

@bcmills bcmills removed the CherryPickCandidate Used during the release process for point releases label Mar 30, 2020
@bcmills bcmills added this to the Go1.15 milestone Mar 30, 2020
@gopherbot
Copy link

Change https://golang.org/cl/226461 mentions this issue: os/signal: make TestStop resilient to initially-blocked signals

gopherbot pushed a commit that referenced this issue Mar 30, 2020
os/signal: in TestStop, skip the final "unexpected signal" check for …
fde6868 
…SIGUSR1 on Android

In CL 226138, I updated TestStop to have more uniform behavior for its signals.
However, that test seems to always fail for SIGUSR1 on the Android ARM builders.

I'm not sure what's special about Android for this particular case,
but let's skip the test to unbreak the builders while I investigate.

For #38165
Updates #33174

Change-Id: I35a70346cd9757a92acd505a020bf95e6871405c
Reviewed-on: https://go-review.googlesource.com/c/go/+/226458
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
2 participants
@bcmills @gopherbot