New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: TestWaitGroupMisuse2 is flaky #38163
Comments
I propose that we just delete this test. It has become a time sink and I don't think there is any way to make it truly reliable. It is testing a race condition between two pieces of code that is fundamentally impossible to guarantee, especially on a VM where the underlying hardware is oversubscribed. The error condition detection that it is testing for is optional - losing it would not affect correct programs - and overlaps with the checks that |
Change https://golang.org/cl/340249 mentions this issue: |
Looks like the flakes are for some reason quite bad on
2021-10-12T20:20:41-d032b2b/windows-arm64-10 |
@gopherbot Please backport to Go 1.17 as a test-only fix. The |
Backport issue(s) opened: #52306 (for 1.17). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases. |
Change https://go.dev/cl/399821 mentions this issue: |
…tGroupMisuse3 These tests are inherently nondeterministic: They exercise a racy code path for up to one million iterations, and require that an error occur at least once. TestWaitGroupMisuse2 in particular is an ongoing source of trybot flakiness. Updates #38163. Fixes #52306. Change-Id: Ibbbda2c998c915333487ad262d3df6829de01c2b Reviewed-on: https://go-review.googlesource.com/c/go/+/340249 Trust: Damien Neil <dneil@google.com> Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Damien Neil <dneil@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dmitry Vyukov <dvyukov@google.com> (cherry picked from commit 011fd00) Reviewed-on: https://go-review.googlesource.com/c/go/+/399821 Run-TryBot: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Damien Neil <dneil@google.com>
2020-03-30T17:35:19-3ee782b/linux-s390x-ibm
2020-03-22T08:44:07-683c266/aix-ppc64
2020-03-22T00:10:27-36b815e/linux-s390x-ibm
2019-10-24T12:09:29-a42a396/solaris-amd64-oraclerel
2019-10-03T20:43:01-3ad3508/aix-ppc64
2019-09-24T04:16:35-ced2454/aix-ppc64
2019-09-16T11:56:15-49e7c76/solaris-amd64-oraclerel
2019-09-12T14:09:30-c20eb96/solaris-amd64-oraclerel
2019-09-10T14:25:46-f668573/solaris-amd64-oraclerel
2019-08-28T10:43:11-5fb74fc/solaris-amd64-oraclerel
2019-08-25T16:47:03-89fb80f/solaris-amd64-oraclerel
2019-06-06T19:56:56-d32ec38/aix-ppc64
2019-06-05T23:57:39-e9073ef/aix-ppc64
2019-05-30T22:39:04-3cee550/aix-ppc64
2019-05-30T17:59:57-220552f/aix-ppc64
2019-05-30T15:38:43-16796af/aix-ppc64
2019-05-30T12:00:59-a0c96a9/aix-ppc64
2019-05-29T21:31:37-913d290/aix-ppc64
2019-05-29T01:10:13-200176e/aix-ppc64
2019-04-30T16:59:13-f686a28/aix-ppc64
See previously #22944, #20072, #11443.
(CC @dvyukov @bradfitz @aclements @ianlancetaylor)
The text was updated successfully, but these errors were encountered: