Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: TestLayersTimeout flake on android-386-emu builder #38161

Closed
bcmills opened this issue Mar 30, 2020 · 1 comment
Closed

context: TestLayersTimeout flake on android-386-emu builder #38161

bcmills opened this issue Mar 30, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 30, 2020

2020-03-30T17:25:29-33b648c/android-386-emu

--- FAIL: TestLayersTimeout (0.00s)
    context_test.go:550: seed=1585589553608094940: ctx should not be canceled yet
    context_test.go:598: context.Background.WithCancel.WithCancel.WithValue(type *context.value, val <not Stringer>).WithValue(type *context.value, val <not Stringer>).WithDeadline(2020-03-30 17:32:33.60919623 +0000 UTC m=+0.216396871 [-725.66µs]).WithCancel.WithValue(type *context.value, val <not Stringer>).WithValue(type *context.value, val <not Stringer>).WithCancel.WithCancel.WithCancel.WithValue(type *context.value, val <not Stringer>).WithCancel.WithValue(type *context.value, val <not Stringer>).WithValue(type *context.value, val <not Stringer>).WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithValue(type *context.value, val <not Stringer>).WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithValue(type *context.value, val <not Stringer>).WithValue(type *context.value, val <not Stringer>).WithValue(type *context.value, val <not Stringer>)
FAIL
exitcode=1FAIL	context	0.418s

I replaced a moderate-duration timeout with a short-duration one in CL 223019. Probably this condition needs to be updated not to be sensitive to whether the timeout fires before or after that point in the code.

@bcmills bcmills self-assigned this Mar 30, 2020
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. labels Mar 30, 2020
@bcmills bcmills added this to the Go1.15 milestone Mar 30, 2020
@gopherbot
Copy link

Change https://golang.org/cl/226457 mentions this issue: context: fix a flaky timeout in TestLayersTimeout

@golang golang locked and limited conversation to collaborators Mar 31, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants