Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: conversion from int/float typed constant to complex variable changed in 1.14 [1.13 backport] #38122

Closed
gopherbot opened this issue Mar 28, 2020 · 2 comments
Closed

cmd/compile: conversion from int/float typed constant to complex variable changed in 1.14 [1.13 backport] #38122

gopherbot opened this issue Mar 28, 2020 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.13.10

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #38117 to be considered for backport to the next 1.13 minor release.

Looks like we're going back to the 1.13 behavior. I'll let @griesemer review the CL, but:

@gopherbot Please open a backport to 1.14.

The compiler behavior changed the way it handles constant conversions. This can break existing programs with no workaround other than rewriting the program, which should not be needed.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 28, 2020
@gopherbot gopherbot mentioned this issue Mar 28, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.10 milestone Mar 28, 2020
@ianlancetaylor
Copy link
Contributor

We only need a backport to 1.14, and I only asked for a backport to 1.14, not sure why gopherbot opened this issue for 1.13.

@ianlancetaylor
Copy link
Contributor

Oh, I see, it's because I mentioned 1.13 in the comment separately from the gopherbot request.

@dmitshur dmitshur mentioned this issue May 7, 2020
Open
@dmitshur dmitshur removed the CherryPickCandidate Used during the release process for point releases label May 8, 2020
@golang golang locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.13.10
Development

No branches or pull requests
3 participants
@dmitshur @ianlancetaylor @gopherbot