Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: update where NOFRAME is valid #38110

Open
randall77 opened this issue Mar 27, 2020 · 4 comments
Open

cmd/asm: update where NOFRAME is valid #38110

randall77 opened this issue Mar 27, 2020 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Documentation NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@randall77
Copy link
Contributor

The current comment for NOFRAME in runtime/textflag.h says:

// TODO(mwhudson): only implemented for ppc64x at present.

It's been implemented for lots (all?) architectures since.
Check our coverage and update (delete) this comment.

@mwhudson @zhangfannie
@randall77 randall77 added this to the Unplanned milestone Mar 27, 2020
@cherrymui
Copy link
Member

Yeah, I think it is implemented in nearly all architectures. If I remember correctly, @aclements did that.

@cherrymui
Copy link
Member

CL https://go-review.googlesource.com/c/go/+/92039 and the stack.

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 27, 2020
@gopherbot
Copy link

Change https://golang.org/cl/226284 mentions this issue: runtime: remove TODO comment about NOFRAME, now done

@mwhudson
Copy link
Contributor

Oh yay, glad that got done!

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Documentation NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@andybons @mwhudson @randall77 @gopherbot @cherrymui