Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: remove ellipses from test names #38103

Closed
stamblerre opened this issue Mar 27, 2020 · 1 comment
Closed

x/tools/gopls: remove ellipses from test names #38103

stamblerre opened this issue Mar 27, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.0

Comments

@stamblerre
Copy link
Contributor

Our test names seem to have ... in them, for example: TestSource/Modules/../testdata/lsp/References/refs_33_8/refs-declaration-false. This makes them a little bit difficult to work with. I believe this happened as a result of @ridersofrohan's changes to go/packages/packagestest. @ridersofrohan: Would it be possible to remove the ellipses from the test names?
@stamblerre stamblerre added this to the gopls/v0.4.0 milestone Mar 27, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 27, 2020
@ridersofrohan ridersofrohan self-assigned this Mar 30, 2020
@gopherbot
Copy link

Change https://golang.org/cl/226377 mentions this issue: internal/lsp/tests: remove ellipses from test names

@golang golang locked and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.0
Development

No branches or pull requests
3 participants
@ridersofrohan @stamblerre @gopherbot