Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/trace: crash because of deprecated HTML Imports in web view #38054

Closed
mmathys opened this issue Mar 24, 2020 · 2 comments
Closed

cmd/trace: crash because of deprecated HTML Imports in web view #38054

mmathys opened this issue Mar 24, 2020 · 2 comments
Labels
FrozenDueToAge

Comments

@mmathys
Copy link

mmathys commented Mar 24, 2020 •
edited

What version of Go are you using (go version)?

go version go1.14 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

Chrome 80.0.3987.132 MacOS

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/max/Library/Caches/go-build"
GOENV="/Users/max/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/max/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rg/bvn53d7j0wbfnxkw_fktlsq40000gn/T/go-build837065189=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Run the go trace tool:go tool trace -http=':8081' trace.out on any trace. Then, navigate to to View Trace. This page is using a HTML imports, which have been deprecated in Chrome M80.

What did you expect to see?

The trace tool.

What did you see instead?

An empty page and an error in the console:

HTML Imports is deprecated and has now been removed as of M80. See https://www.chromestatus.com/features/5144752345317376 and https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade for more details.
Uncaught ReferenceError: tr is not defined
    at onResult (trace:59)
    at trace:43
@seankhliao
Copy link
Member

seankhliao commented Mar 24, 2020 •
edited

should be fixed in #37343

@odeke-em odeke-em changed the title Go Trace Tool: Web tool crashes because of deprecated HTML Imports cmd/trace: Go Trace Tool: Webcrashes because of deprecated HTML Imports Mar 25, 2020
@odeke-em odeke-em changed the title cmd/trace: Go Trace Tool: Webcrashes because of deprecated HTML Imports cmd/trace: crash because of deprecated HTML Imports in web view Mar 25, 2020
@andybons
Copy link
Member

Duplicate of #34374

@andybons andybons marked this as a duplicate of #34374 Mar 25, 2020
@golang golang locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andybons @mmathys @gopherbot @seankhliao