Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: remove unused isIntOrdering method #37989

Closed
AlphaHot opened this issue Mar 21, 2020 · 2 comments
Closed

cmd/compile: remove unused isIntOrdering method #37989

AlphaHot opened this issue Mar 21, 2020 · 2 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@AlphaHot
Copy link

go/src/cmd/compile/internal/gc/walk.go

Lines 3530 to 3538 in d467f3b

// isIntOrdering reports whether n is a <, ≤, >, or ≥ ordering between integers.
func (n *Node) isIntOrdering() bool {
switch n.Op {
case OLE, OLT, OGE, OGT:
default:
return false
}
return n.Left.Type.IsInteger() && n.Right.Type.IsInteger()
}

@ianlancetaylor ianlancetaylor changed the title Suggestion to delete an unused method cmd/compile: remove unused isIntOrdering method Mar 21, 2020
@ianlancetaylor ianlancetaylor added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Mar 21, 2020
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Mar 21, 2020
@ianlancetaylor
Copy link
Contributor

CC @mundaym

@gopherbot
Copy link

Change https://golang.org/cl/224777 mentions this issue: cmd/compile: remove unused isIntOrdering method

@golang golang locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @AlphaHot